Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticks in the linear viewer are 1 base off #278

Closed
cmonnom opened this issue Dec 16, 2024 · 2 comments
Closed

Ticks in the linear viewer are 1 base off #278

cmonnom opened this issue Dec 16, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@cmonnom
Copy link

cmonnom commented Dec 16, 2024

Describe the bug

Ticks under the sequence in the linear viewer are placed under the wrong base.

For example, the tick labeled "1" is under the 1st base which is at index 0.

Expected behavior

Since everything is 0-based, the tick should either start at 0, or (better?) placed between the 1st and 2nd amino acid.

Maybe something like this:
image

Rather than the current:

image

Screenshots

image

Your environment:

Windows 11
Chrome 131.0.6778.140

@cmonnom cmonnom added the bug Something isn't working label Dec 16, 2024
@jjti
Copy link
Collaborator

jjti commented Dec 16, 2024

Hey @cmonnom, as you've flagged the UI is 1-based while the input/output are 0-based. I'm not sure we can change that now, though, without breaking folks' existing workflows (which would be worse than fixing it). Further, IIRC most tools biologists use are 1-based so that's what the viewers attempt to show: 1-based indexes

Would it help if the demo were fixed? I agree that header being 0-based is strange given all the rest of it.

@cmonnom
Copy link
Author

cmonnom commented Dec 16, 2024

Hi @jjti , I think I understand what you mean: SeqViz internals use a 0-based system but what's shown to the user is a 1-based index. (what users of the library have access to are the 0-based start/end).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants