Stopped modifying original argument in $.create(), as that creates we…

…ird bugs when the object is not disposable
LeaVerou · Jan 30, 2016 · 11ae2e2 · 11ae2e2
1 parent 2bc1cdf
commit 11ae2e2
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/bliss.js b/bliss.js
@@ -115,7 +115,7 @@ extend($, {
 			else {
 				o = tag;
 				tag = o.tag;
-				delete o.tag;
+				o = $.extend({}, o, function(property) { return property !== "tag"; });
 			}
 		}
 
@@ -689,7 +689,7 @@ if (self.EventTarget && "addEventListener" in EventTarget.prototype) {
 	    notEqual = function() { return !equal.apply(this, arguments); };
 
 	EventTarget.prototype.addEventListener = function(type, callback, capture) {
-		if (this[_] && callback) {
+		if (this && this[_] && callback) {
 			var listeners = this[_].bliss.listeners = this[_].bliss.listeners || {};
 
 			listeners[type] = listeners[type] || [];
@@ -703,7 +703,7 @@ if (self.EventTarget && "addEventListener" in EventTarget.prototype) {
 	};
 
 	EventTarget.prototype.removeEventListener = function(type, callback, capture) {
-		if (this[_] && callback) {
+		if (this && this[_] && callback) {
 			var listeners = this[_].bliss.listeners = this[_].bliss.listeners || {};
 
 			if (listeners[type]) {
@@ -719,4 +719,4 @@ if (self.EventTarget && "addEventListener" in EventTarget.prototype) {
 self.$ = self.$ || $;
 self.$$ = self.$$ || $.$;
 
-})(Bliss);
+})(Bliss);
diff --git a/bliss.min.js b/bliss.min.js
diff --git a/bliss.shy.js b/bliss.shy.js
@@ -115,7 +115,7 @@ extend($, {
 			else {
 				o = tag;
 				tag = o.tag;
-				delete o.tag;
+				o = $.extend({}, o, function(property) { return property !== "tag"; });
 			}
 		}