Skip to content

Commit 11ae2e2

Browse files
committed
Stopped modifying original argument in $.create(), as that creates weird bugs when the object is not disposable
1 parent 2bc1cdf commit 11ae2e2

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

bliss.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ extend($, {
115115
else {
116116
o = tag;
117117
tag = o.tag;
118-
delete o.tag;
118+
o = $.extend({}, o, function(property) { return property !== "tag"; });
119119
}
120120
}
121121

@@ -689,7 +689,7 @@ if (self.EventTarget && "addEventListener" in EventTarget.prototype) {
689689
notEqual = function() { return !equal.apply(this, arguments); };
690690

691691
EventTarget.prototype.addEventListener = function(type, callback, capture) {
692-
if (this[_] && callback) {
692+
if (this && this[_] && callback) {
693693
var listeners = this[_].bliss.listeners = this[_].bliss.listeners || {};
694694

695695
listeners[type] = listeners[type] || [];
@@ -703,7 +703,7 @@ if (self.EventTarget && "addEventListener" in EventTarget.prototype) {
703703
};
704704

705705
EventTarget.prototype.removeEventListener = function(type, callback, capture) {
706-
if (this[_] && callback) {
706+
if (this && this[_] && callback) {
707707
var listeners = this[_].bliss.listeners = this[_].bliss.listeners || {};
708708

709709
if (listeners[type]) {
@@ -719,4 +719,4 @@ if (self.EventTarget && "addEventListener" in EventTarget.prototype) {
719719
self.$ = self.$ || $;
720720
self.$$ = self.$$ || $.$;
721721

722-
})(Bliss);
722+
})(Bliss);

bliss.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bliss.shy.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ extend($, {
115115
else {
116116
o = tag;
117117
tag = o.tag;
118-
delete o.tag;
118+
o = $.extend({}, o, function(property) { return property !== "tag"; });
119119
}
120120
}
121121

0 commit comments

Comments
 (0)