Modified clusters to remain spidered when markers are added or removed. #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remove your dist/ changes from this PR. |
| @@ -37,6 +37,26 @@ L.MarkerCluster = L.Marker.extend({ | |||
| return storageArray; | |||
| }, | |||
|
|
|||
| // Searches through self and all decendants for a given marker. Returns the cluster that directly contains it. | |||
| getClusterDirectlyContaining: function (marker) { | |||
There was a problem hiding this comment.
Can we just use marker.__parent instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code attempts to fix issue 318.
It works via keeping track of what markers are currently visible in the spidered cluster when adding or removing markers. It then searches for the base cluster at the current zoom level and expands it.