Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Improve Repository Layer #2622

Open
marcelfolaron opened this issue Aug 23, 2024 · 0 comments
Open

[Cleanup] Improve Repository Layer #2622

marcelfolaron opened this issue Aug 23, 2024 · 0 comments

Comments

@marcelfolaron
Copy link
Contributor

There are various improvement needs to our repository layer:

Repositories
Interface: IRepository (query, get, create, update, patch, delete)

Returns
Collection (search() )
T (get())
Bool (delete(), update(), patch )
Int (create() )

In case of failures it would throw exceptions
Additionally we should split up some of the queries. Our repo return objects are quite large and often times contain various domain objects (tickets and projects for example).
Instead the repos should focus on the objects they are dealing with. The services can then concatenate the data from multiple repositories if needed. With our move to htmx we may not actually need to do that very often and can just kick of an asynchronous call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant