common-util: use a more robust way to test process invocations

Author: mtf90

commons/util/src/test/java/net/automatalib/common/util/process/ProcessUtilTest.java

@@ -28,16 +28,18 @@
 @Test
 public class ProcessUtilTest {
 
-    private final String process;
+    private final String program;
+    private final String path;
 
     public ProcessUtilTest() {
-        this.process = Objects.requireNonNull(ProcessUtilTest.class.getResource("/process.py")).getPath();
+        this.program = "python";
+        this.path = Objects.requireNonNull(ProcessUtilTest.class.getResource("/process.py")).getPath();
     }
 
     @BeforeTest
     public void setUp() {
         try {
-            if (ProcessUtil.invokeProcess(new String[] {"python", "--version"}) != 0) {
+            if (ProcessUtil.invokeProcess(new String[] {program, "--version"}) != 0) {
                 throw new SkipException("python not supported");
             }
         } catch (IOException | InterruptedException e) {
@@ -47,35 +49,35 @@ public void setUp() {
 
     @Test
     public void testReturnValue() throws IOException, InterruptedException {
-        Assert.assertEquals(ProcessUtil.invokeProcess(new String[] {process, "abc"}), 0);
-        Assert.assertEquals(ProcessUtil.invokeProcess(new String[] {process, "abc", "def"}), 1);
+        Assert.assertEquals(ProcessUtil.invokeProcess(new String[] {program, path, "abc"}), 0);
+        Assert.assertEquals(ProcessUtil.invokeProcess(new String[] {program, path, "abc", "def"}), 1);
 
-        Assert.assertEquals(ProcessUtil.invokeProcess(new String[] {process}, new StringReader("abc")), 0);
-        Assert.assertEquals(ProcessUtil.invokeProcess(new String[] {process}, new StringReader("abc def")), 1);
+        Assert.assertEquals(ProcessUtil.invokeProcess(new String[] {program, path}, new StringReader("abc")), 0);
+        Assert.assertEquals(ProcessUtil.invokeProcess(new String[] {program, path}, new StringReader("abc def")), 1);
     }
 
     @Test
     public void testProcessOutput() throws IOException, InterruptedException {
         StringJoiner stdOutJoiner = new StringJoiner("\n");
         StringJoiner stdErrBuilder = new StringJoiner("\n");
 
-        Assert.assertEquals(ProcessUtil.invokeProcess(new String[] {process, "abc"},
+        Assert.assertEquals(ProcessUtil.invokeProcess(new String[] {program, path, "abc"},
                                                       stdOutJoiner::add,
                                                       stdErrBuilder::add), 0);
         Assert.assertEquals(stdOutJoiner.toString(), "294");
         Assert.assertEquals(stdErrBuilder.toString(), "abc");
 
         stdOutJoiner = new StringJoiner("\n");
         stdErrBuilder = new StringJoiner("\n");
-        Assert.assertEquals(ProcessUtil.invokeProcess(new String[] {process, "abc", "def"},
+        Assert.assertEquals(ProcessUtil.invokeProcess(new String[] {program, path, "abc", "def"},
                                                       stdOutJoiner::add,
                                                       stdErrBuilder::add), 1);
         Assert.assertEquals(stdOutJoiner.toString(), "294\n303");
         Assert.assertEquals(stdErrBuilder.toString(), "abc\ndef");
 
         stdOutJoiner = new StringJoiner("\n");
         stdErrBuilder = new StringJoiner("\n");
-        Assert.assertEquals(ProcessUtil.invokeProcess(new String[] {process},
+        Assert.assertEquals(ProcessUtil.invokeProcess(new String[] {program, path},
                                                       new StringReader("abc"),
                                                       stdOutJoiner::add,
                                                       stdErrBuilder::add), 0);
@@ -84,7 +86,7 @@ public void testProcessOutput() throws IOException, InterruptedException {
 
         stdOutJoiner = new StringJoiner("\n");
         stdErrBuilder = new StringJoiner("\n");
-        Assert.assertEquals(ProcessUtil.invokeProcess(new String[] {process},
+        Assert.assertEquals(ProcessUtil.invokeProcess(new String[] {program, path},
                                                       new StringReader("abc def"),
                                                       stdOutJoiner::add,
                                                       stdErrBuilder::add), 1);