Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move client-side socket subscription logic to action creators #1054

Open
heyheyjp opened this issue Jul 26, 2017 · 0 comments
Open

Move client-side socket subscription logic to action creators #1054

heyheyjp opened this issue Jul 26, 2017 · 0 comments

Comments

@heyheyjp
Copy link
Collaborator

We have container components directly managing connections to sockets, but since ultimately when data is received it gets dispatched and held in redux stores, there's no need to have this logic in the container. We'll move it to the action creators, where all other API-interfacing logic is encapsulated for the web client. The container will only need to invoke actions for subscribing and unsubscribing...then receive the data as usual through props/state from the connected redux stores.

@heyheyjp heyheyjp changed the title Move socket listening logic to action creators Move client-side socket subscription logic to action creators Jul 26, 2017
@heyheyjp heyheyjp self-assigned this Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant