Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Android 14 usb support #7786

Open
jorbuedo opened this issue Sep 10, 2024 · 3 comments
Open

[Bug]: Android 14 usb support #7786

jorbuedo opened this issue Sep 10, 2024 · 3 comments
Labels
bug Something isn't working libraries Impacts the Libraries triage In need of triage

Comments

@jorbuedo
Copy link

jorbuedo commented Sep 10, 2024

Impacted Library name

@ledgerhq/react-native-hid

Impacted Library version

all

Describe the bug

After upgrading Android project to sdk 34 (which is now required to publish to play store), the following error occurs:

One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts

Expected behavior

App should not crash when using the library.

Additional context

https://stackoverflow.com/a/77276774

Lines:

and

getReactApplicationContext().registerReceiver(receiver, intFilter);

Need to be updated to include RECEIVER_NOT_EXPORTED like

getReactApplicationContext().registerReceiver(receiver, intFilter, RECEIVER_NOT_EXPORTED); 

Or rather this for retrocompatibility

        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
            getReactApplicationContext().registerReceiver(receiver, intFilter, Context.RECEIVER_NOT_EXPORTED);
        } else {
            getReactApplicationContext().registerReceiver(receiver, intFilter);
        }
@jorbuedo jorbuedo added bug Something isn't working libraries Impacts the Libraries triage In need of triage labels Sep 10, 2024
nicolas-meilan added a commit to nicolas-meilan/RungeCoin that referenced this issue Sep 18, 2024
Known error:
[java.lang.SecurityException: com.RungeCoin.debug: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts]

fix with patch package or wait until new update fix it.
LedgerHQ/ledger-live#7786
nicolas-meilan added a commit to nicolas-meilan/RungeCoin that referenced this issue Sep 23, 2024
- Fix error on hw usb connection
- Add timer to dispatch error by time
LedgerHQ/ledger-live#7786
nicolas-meilan added a commit to nicolas-meilan/RungeCoin that referenced this issue Sep 23, 2024
- Fix error on hw usb connection
- Add timer to dispatch error by time
LedgerHQ/ledger-live#7786
nicolas-meilan added a commit to nicolas-meilan/ledger-live that referenced this issue Sep 24, 2024
nicolas-meilan added a commit to nicolas-meilan/ledger-live that referenced this issue Sep 24, 2024
nicolas-meilan added a commit to nicolas-meilan/ledger-live that referenced this issue Sep 25, 2024
@nicolas-meilan
Copy link

I create this PR that fix the error: #7880

nicolas-meilan added a commit to nicolas-meilan/ledger-live that referenced this issue Sep 27, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label, comment, or consider closing it.

@github-actions github-actions bot added the Stale label Oct 25, 2024
@jorbuedo
Copy link
Author

Still an issue, the PR is just stuck it seems.

@github-actions github-actions bot removed the Stale label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libraries Impacts the Libraries triage In need of triage
Projects
None yet
Development

No branches or pull requests

2 participants