[Flutter] API Keyなどの秘匿情報の管理 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ができない問題を対応ページングができない問題を対応
LeoAndo
commented
Feb 14, 2023
Comment on lines
+24
to
+26
| !.vscode/settings.json | ||
| !.vscode/launch.json | ||
| !.vscode/extensions.json |
There was a problem hiding this comment.
チーム内で開発環境を統一するために必要なjsonファイルのみgit管理対象にする
LeoAndo
commented
Feb 14, 2023
| "robert-brunhage.flutter-riverpod-snippets", // riverpod | ||
| // "alexisvt.flutter-snippets", // flutter widget snippets | ||
| ] | ||
| } |
There was a problem hiding this comment.
https://de-milestones.com/vscode-how-to-setup-recommended-tools/
拡張機能を統一させるための設定ファイル
LeoAndo
commented
Feb 14, 2023
| ] | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
vscode上で、「実行とデバッグ」をクリックして実行する場合に指定できるビルドタイプの設定ファイル
LeoAndo
commented
Feb 14, 2023
| "editor.wordBasedSuggestions": false, | ||
| }, | ||
| "dart.openDevTools": "flutter", | ||
| } |
There was a problem hiding this comment.
Editorの設定やflutter fvmの設定周りの共有用の設定ファイル
LeoAndo
commented
Feb 14, 2023
| "flavor": "development", | ||
| "flutterAppName": "(Dev)GithubSearch", | ||
| "flutterApplicationIdSuffix": ".development", | ||
| "githubAccessToken": "", |
There was a problem hiding this comment.
秘匿情報はここの設定値をローカル環境にて各自書き換える。
LeoAndo
commented
Feb 14, 2023
| @@ -14,7 +14,7 @@ final Provider githubApiProvider = Provider<GithubApi>((_) { | |||
| }); | |||
|
|
|||
| class GithubApi { | |||
| static const _authority = 'api.github.com'; | |||
| static const _authority = String.fromEnvironment('githubApiDomain'); | |||
There was a problem hiding this comment.
LeoAndo
commented
Feb 14, 2023
| @@ -10,10 +10,11 @@ import 'package:flutter_github_search/data/api/http_handler.dart'; | |||
| import 'package:flutter_github_search/domain/exception/api_exceptions.dart'; | |||
|
|
|||
| class GithubApiHttpClient extends http.BaseClient { | |||
| // static const String _accessToken = "INPUT HERE TOKEN"; | |||
| static const String _accessToken = | |||
| String.fromEnvironment('githubAccessToken'); | |||
There was a problem hiding this comment.
LeoAndo
commented
Feb 14, 2023
| )), | ||
| ); | ||
| } | ||
| } |
LeoAndo
commented
Feb 14, 2023
| ), | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
package情報確認用画面
application idとかアプリ名とかを環境毎に変えたので。
LeoAndo
commented
Feb 14, 2023
| @@ -213,6 +239,7 @@ class _SearchPagingScreenState extends ConsumerState<SearchPagingScreen> { | |||
| } | |||
| } | |||
| } | |||
| // Androidで動作 - END | |||
| return false; | |||
| }, | |||
| ); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues (任意)
close #8
修正内容 (必須)
refs (任意)
https://zenn.dev/altiveinc/articles/separating-environments-in-flutter
https://pub.dev/packages/package_info_plus/example