POST /v1/holders accepts invalid type value — missing enum validation

[gandalf-at-lerian]

Description

The POST /v1/holders endpoint accepts any string for the type field, including invalid values like "INVALID". A holder is created successfully (201) even though the type should be restricted to NATURAL_PERSON or LEGAL_PERSON.

Root Cause

In pkg/mmodel/holder.go, the CreateHolderInput.Type field uses:

Type *string `json:"type" validate:"required" example:"NATURAL_PERSON" enums:"NATURAL_PERSON,LEGAL_PERSON"`

The enums tag is a Swagger/documentation annotation only — it does not trigger validation. The validate tag only checks required, not the allowed values.

For comparison, alias.go correctly uses oneof in the validate tag:

Role string `json:"role" validate:"required,oneof=PRIMARY_HOLDER LEGAL_REPRESENTATIVE RESPONSIBLE_PARTY"`

Expected Behavior

When type is not one of NATURAL_PERSON or LEGAL_PERSON, the API should return:

• HTTP 400
• A structured error indicating the invalid field value

Suggested Fix

Add oneof to the validate tag:

Type *string `json:"type" validate:"required,oneof=NATURAL_PERSON LEGAL_PERSON" example:"NATURAL_PERSON" enums:"NATURAL_PERSON,LEGAL_PERSON"`

[lerian-studio]

This issue has had no activity for 30 days and is now marked stale. It will be closed in 7 days unless updated. Add the no-stale label to keep it open indefinitely.

Learn more about the routine and exempt labels: https://github.com/LerianStudio/github-actions-shared-workflows/blob/main/instructions/repository-routines.md