Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse ASYNC used with 2 unimplemented functions cause UnhandledPromiseRejectionWarning #44

Open
KageAkuma75 opened this issue Oct 18, 2021 · 0 comments

Comments

@KageAkuma75
Copy link

Hi Lester,

I have an issue with parseAsync :

If both arguments use not implemented function then we have an UnhandledPromiseRejectionWarning.

You can reproduce with this formula "SUM(NOTIMP1(2,1), NOTIMP2(3,4))"

I found a workaround by changing line 191 of /grammar/hooks.js from
'throw FormulaError.NOT_IMPLEMENTED(name);' to
'return FormulaError.NOT_IMPLEMENTED(name);' and it seems to work.

Best regards,

Jacques Loriot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant