Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about OrientedRepPointsHead.loss() #41

Open
crisz94 opened this issue Jun 6, 2023 · 0 comments
Open

Questions about OrientedRepPointsHead.loss() #41

crisz94 opened this issue Jun 6, 2023 · 0 comments

Comments

@crisz94
Copy link

crisz94 commented Jun 6, 2023

Hi @LiWentomng , thanks for your execellent work!

In orientedreppoints_head.py, line 371 to line 381 seems to compute proposals to get targets of refine stage. But the computation of proposals are different from the funtion offset_to_pts(). More specifically, offset_to_pts() use pts_shift as yx_pts_shift, but line 371 to line 381 in orientedreppoints_head.py uses points_shift as xy_pts_shift.

Consequently, pts_preds_init is used differently in forward() and loss() and this may lead to some unpredicted results. Did I misunderstand your code? It's really confused, hope to get your respond soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant