Skip to content

Commit 3ede10b

Browse files
authored
Fix example variables
* Drop environment variables LB_UPLOADS_IMAGE_UPLOAD_URL and LB_UPLOADS_RESERVATION_ATTACHMENT_PATH from the various lb environment files in order to retain upstream defaults * Add environment variable LB_SCRIPT_URL to the various lb environment files in order to enable attaching an image to a resource * Review the documentation files * Add the environment file proxy.env to file docker-compose-public.yml Closes: #213
1 parent d928ad1 commit 3ede10b

7 files changed

Lines changed: 14 additions & 14 deletions

File tree

‎.examples/docker/docker-compose-public.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ services:
1111
- proxy_certs:/etc/nginx/certs
1212
- proxy_html:/usr/share/nginx/html
1313
- /var/run/docker.sock:/tmp/docker.sock:ro
14+
env_file:
15+
- proxy.env
1416
acme:
1517
image: ${DOCKER_ACME_IMAGE:-nginxproxy/acme-companion}:${DOCKER_ACME_TAG:-latest}
1618
restart: always

‎.examples/docker/lb.env‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@ LB_LOGGING_FOLDER=/var/log/librebooking
77
LB_LOGGING_LEVEL=DEBUG
88
LB_LOGGING_SQL=false
99
LB_DEFAULT_TIMEZONE=Europe/Zurich
10-
LB_UPLOADS_IMAGE_UPLOAD_URL=Web/uploads/images
11-
LB_UPLOADS_RESERVATION_ATTACHMENT_PATH=Web/uploads/reservation
10+
LB_SCRIPT_URL=http://localhost:8080/Web
11+

‎.examples/docker/lb1.env‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@ LB_LOGGING_FOLDER=/var/log/librebooking
77
LB_LOGGING_LEVEL=ERROR
88
LB_LOGGING_SQL=false
99
LB_DEFAULT_TIMEZONE=Europe/Zurich
10-
LB_UPLOADS_IMAGE_UPLOAD_URL=Web/uploads/images
11-
LB_UPLOADS_RESERVATION_ATTACHMENT_PATH=Web/uploads/reservation
10+
LB_SCRIPT_URL=https://acme.org/Web
11+

‎.examples/docker/lb2.env‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,4 @@ LB_LOGGING_FOLDER=/var/log/librebooking
77
LB_LOGGING_LEVEL=ERROR
88
LB_LOGGING_SQL=false
99
LB_DEFAULT_TIMEZONE=Europe/Zurich
10-
LB_UPLOADS_IMAGE_UPLOAD_URL=Web/uploads/images
11-
LB_UPLOADS_RESERVATION_ATTACHMENT_PATH=Web/uploads/reservation
10+
LB_SCRIPT_URL=https://acme.org/Web

‎.examples/podman/lb.env‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,3 @@ LB_LOGGING_FOLDER=/var/log/librebooking
77
LB_LOGGING_LEVEL=DEBUG
88
LB_LOGGING_SQL=false
99
LB_DEFAULT_TIMEZONE=Europe/Zurich
10-
LB_UPLOADS_IMAGE_UPLOAD_URL=Web/uploads/images
11-
LB_UPLOADS_RESERVATION_ATTACHMENT_PATH=Web/uploads/reservation

‎RUN.md‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,16 @@ From version-3, this docker image makes full usage of the
1818
| LB_DATABASE_HOSTSPEC | | Database network address |
1919
| LB_INSTALL_PASSWORD | | Librebooking installation password |
2020
| LB_DEFAULT_TIMEZONE | | Timezone |
21+
| LB_SCRIPT_URL | | Script URL such as `http://localhost:8080/Web` |
2122
| LB_LOGGING_FOLDER | `/var/log/librebooking` | Logs folder |
2223
| LB_LOGGING_LEVEL | `none` | Logging level |
2324
| LB_LOGGING_SQL | `false` | SQL logging |
2425

2526
### Optional variables
2627

27-
| Variable | Description |
28-
| -------- | ----------- |
29-
| APP_PATH | URL path |
28+
| Variable | Description |
29+
| -------- | --------------- |
30+
| APP_PATH | custom URL path |
3031

3132
## Optional mounts
3233

‎SETUP.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@
55
### Database initialization
66

77
1. Point your web browser to `<YOUR_HOST>/install` or `<YOUR_HOST>/<YOUR_PATH>/install`
8-
(if you are using a custom URL-path)
9-
- Enter the installation password (docker variable `LB_INSTALL_PWD`)
8+
(if you are using a custom URL-path with environment variable `APP_PATH`)
9+
- Enter the installation password (environment variable `LB_INSTALL_PWD`)
1010
- Enter the database root user: `root`
11-
- Enter the database root password (docker variable `MYSQL_ROOT_PASSWORD`)
11+
- Enter the database root password (environment variable `MYSQL_ROOT_PASSWORD`)
1212
- Select `Create the database`
1313
- Select `Create the database user`
1414
- Click on the register link, at the bottom of the web page

0 commit comments

Comments
 (0)