From 91d0cbcd1cfc54e89d9348f6381cd0515da615c8 Mon Sep 17 00:00:00 2001 From: labmecanicatec <58854556+labmecanicatec@users.noreply.github.com> Date: Mon, 16 Feb 2026 15:31:54 -0500 Subject: [PATCH] refactor(generate-reports): replace native date inputs with flatpickr - Replace jQuery .click handlers with delegated document click (Element.matches) - Remove legacy/commented report handlers (toggle, print, CSV export) - Convert date inputs from type="date" to type="text" (flatpickr) - Remove hidden formatted date fields - Simplify DatePickerSetupControl (use only ControlId) - Minor cleanup: adjust separator, remove comments, fix newline --- Web/scripts/reports/generate-reports.js | 28 ++++++------------------- tpl/Reports/generate-report.tpl | 21 +++++++------------ 2 files changed, 14 insertions(+), 35 deletions(-) diff --git a/Web/scripts/reports/generate-reports.js b/Web/scripts/reports/generate-reports.js index c5e1adaf5..8749e29df 100644 --- a/Web/scripts/reports/generate-reports.js +++ b/Web/scripts/reports/generate-reports.js @@ -24,8 +24,11 @@ function GenerateReports(reportOptions) { wireUpAutocompleteFilters(); - $('.dateinput').click(function () { - $('#range_within').attr('checked', 'checked'); + document.addEventListener('click', function (e) { + if (e.target.matches('.dateinput')) { + const radio = document.getElementById('range_within'); + radio.checked = true; + } }); $('#btnCustomReport').click(function (e) { @@ -43,26 +46,7 @@ function GenerateReports(reportOptions) { ajaxPost(elements.customReportForm, opts.customReportUrl, before, after); }); -/* - $('#showHideCustom').click(function (e) { - e.preventDefault(); - $('#customReportInput-container').toggle(); - }); - - $(document).on('click', '#btnPrint', function (e) { - e.preventDefault(); - - var url = opts.printUrl + elements.customReportForm.serialize(); - window.open(url); - }); - $(document).on('click', '#btnCsv', function (e) { - e.preventDefault(); - - var url = opts.csvUrl + elements.customReportForm.serialize(); - window.open(url); - }); -*/ elements.saveDialog.on('shown.bs.modal', function () { $('#saveReportName').focus(); }); @@ -119,4 +103,4 @@ function GenerateReports(reportOptions) { ajaxPost($('#customReportInput, #saveReportForm'), opts.saveUrl, before, after); }; -} \ No newline at end of file +} diff --git a/tpl/Reports/generate-report.tpl b/tpl/Reports/generate-report.tpl index 7fea7d548..585d16865 100644 --- a/tpl/Reports/generate-report.tpl +++ b/tpl/Reports/generate-report.tpl @@ -120,14 +120,12 @@ class="bi bi-calendar3-range me-1">{translate key=Between} - - - - + +