Skip to content

Commit a93b9f8

Browse files
tellypresencetellypresencekimkulling
authored
[OpenGEX] disable partial implementation of light import (causes model load failure) (assimp#6044)
* Disable OpenGEX lights and cameras which are suspected of causing model load failure * Revert changes to camera import --------- Co-authored-by: tellypresence <[email protected]> Co-authored-by: Kim Kulling <[email protected]>
1 parent 2690e35 commit a93b9f8

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

code/AssetLib/OpenGEX/OpenGEXImporter.cpp

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,8 @@ void OpenGEXImporter::InternReadFile(const std::string &filename, aiScene *pScen
310310

311311
copyMeshes(pScene);
312312
copyCameras(pScene);
313-
copyLights(pScene);
313+
// TODO: lights only partially implemented and breaking model import
314+
// copyLights(pScene);
314315
copyMaterials(pScene);
315316
resolveReferences();
316317
createNodeTree(pScene);
@@ -366,7 +367,8 @@ void OpenGEXImporter::handleNodes(DDLNode *node, aiScene *pScene) {
366367
break;
367368

368369
case Grammar::LightNodeToken:
369-
handleLightNode(*it, pScene);
370+
// TODO: lights only partially implemented and breaking model import
371+
// handleLightNode(*it, pScene);
370372
break;
371373

372374
case Grammar::GeometryObjectToken:
@@ -378,7 +380,8 @@ void OpenGEXImporter::handleNodes(DDLNode *node, aiScene *pScene) {
378380
break;
379381

380382
case Grammar::LightObjectToken:
381-
handleLightObject(*it, pScene);
383+
// TODO: lights only partially implemented and breaking model import
384+
// handleLightObject(*it, pScene);
382385
break;
383386

384387
case Grammar::TransformToken:
@@ -468,7 +471,10 @@ void OpenGEXImporter::handleNameNode(DDLNode *node, aiScene * /*pScene*/) {
468471
}
469472

470473
const std::string name(val->getString());
471-
if (m_tokenType == Grammar::GeometryNodeToken || m_tokenType == Grammar::LightNodeToken || m_tokenType == Grammar::CameraNodeToken) {
474+
if (m_tokenType == Grammar::GeometryNodeToken ||
475+
// TODO: lights only partially implemented and breaking model import
476+
// m_tokenType == Grammar::LightNodeToken ||
477+
m_tokenType == Grammar::CameraNodeToken) {
472478
m_currentNode->mName.Set(name.c_str());
473479
} else if (m_tokenType == Grammar::MaterialToken) {
474480
aiString aiName;

0 commit comments

Comments
 (0)