Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Next" button should not appear for files in "available for signature" state #2780

Open
DazeEnd opened this issue Apr 16, 2024 · 4 comments
Open
Labels
feature-request New feature request frontend Frontend task javascript Pull requests that update Javascript code
Milestone

Comments

@DazeEnd
Copy link

DazeEnd commented Apr 16, 2024

Is your feature request related to a problem? Please describe.
Currently, a "Next" button is displayed for files that are in the "available for signature" state. This "Next" button opens the user interface for placing signature fields.

This "Next" button could be confusing for users (it is certainly confusing to me), because the user is being prompted to continue a process by taking a "Next" action, when they are not in the middle of a process. In fact they probably just finished a process by sending the file to someone else for a signature.

Describe the solution you'd like
When a file is in the "available for signature" state, the "Next" button should not be displayed unless the user adds an additional signer by clicking the "Add signer" button. Ideally a message reading "Waiting for signature" would be displayed where the "Next" button is currently displayed.

Describe alternatives you've considered
Instead of a "Waiting for signature" message, you could replace the "Next" button with a "Cancel" button that cancels the signature request.

Additional context
Current UI as of v8.0.0-rc11:
Screenshot from 2024-04-16 14-12-13
Screenshot from 2024-04-16 14-13-21

Mock-up of one possible solution:
Mock Up

@DazeEnd DazeEnd added the feature-request New feature request label Apr 16, 2024
@github-project-automation github-project-automation bot moved this to 0. Needs triage in Roadmap Apr 16, 2024
@vitormattos
Copy link
Member

This is a good point about UX and also about new feature. I will talk more to be possible we think together and found a good solution.

Next button

The objective of Next button is to go to step to define the position of visible signature and after this, send the file to be signed changing the status from "draft" to "available for signature".

The button do two actions and maybe this could be a problem because we will need to think more about how to split if we identify that is necessary split the next button.

Cancel button

Other point is the action to cancel the signature. We will need to think more about this.... for now, if you open the tree dots menu on each signer, you will see an option to delete the signer. If you delete all, don't will remove the entry from table libresign_file. I think that cancel sound more to delete the entry from libresign_file table, that is the action that will remove the file from LibreSign and turn again to be a simple PDF file at Nextcloud. Have more points to think about to do this:

  • When we delete the file signed.pdf at app files, will trigger a LibreSign job to delete all data about this file at LibreSign tables removing completely the file from LibreSign.
  • When we request to sign a file sending by LibreSign interface, this file is saved at Nextcloud. Here I have a question: what we will do with original file, that is visible at app Files when we cancel the sign request? We will delete the uploaded file or we will maintain the file? If the option is to delete, will be necessary to think how we will delete and if we will delete only the files uploaded by LibreSign because also is possible request to sign a file using the fileId from app Files or from API.

@vitormattos vitormattos added this to the Backlog milestone Apr 24, 2024
@DazeEnd
Copy link
Author

DazeEnd commented Apr 24, 2024

@vitormattos I understand what you're saying about this being two different issues. I would say that a "Cancel Signature" button would be a nice convenience feature, but not required, since individual signatures can be deletes (as you pointed out). If the "Cancel Signature" button would be a roadblock, I think it would be acceptable to separate the issues.

As a first step, I suggest removing or hiding the "Next" button when there is a pending signature. If a user adds a new signer, then the "Next" button could be displayed so that a signature can be placed and the signature request be sent.

You asked:

When we request to sign a file sending by LibreSign interface, this file is saved at Nextcloud. Here I have a question: what we will do with original file, that is visible at app Files when we cancel the sign request? We will delete the uploaded file or we will maintain the file? If the option is to delete, will be necessary to think how we will delete and if we will delete only the files uploaded by LibreSign because also is possible request to sign a file using the fileId from app Files or from API.

My opinion is that canceling a signature request should not delete a file in the Files app. I think that from a user's perspective, things are easier to understand if there is a separation of duties and functions. LibreSign manages signatures, and the Files app manages the actual files and documents. So I would propose the the file remain in Files, even after the signature request is canceled.

@vitormattos
Copy link
Member

As a first step, I suggest removing or hiding the "Next" button when there is a pending signature. If a user adds a new signer, then the "Next" button could be displayed so that a signature can be placed and the signature request be sent.

A point to think: by this way (hiding the "Next" button when there is a pending signature) don't will be possible change the position of visible elements after send to signer and before the file is signed by signer.

@DazeEnd
Copy link
Author

DazeEnd commented Apr 24, 2024

I didn't realize that clicking "Next" on a file with a pending signature would allow you to reposition the signature field. (When I click on Next for a file with a pending signature, the existing signature field is not displayed. Should it be?)

If that button is needed for editing an existing signature request, maybe the label should just be changed from "Next" to "Edit" when the file has a pending signature request.

I'm flexible on how the UI changes. I just think that the UI should somehow change to indicate that the the signature request has already been successfully sent.

@vitormattos vitormattos modified the milestones: Backlog, Next Major (30) Jun 10, 2024
@vitormattos vitormattos moved this from 0. Needs triage to Next release in Roadmap Jun 10, 2024
@vitormattos vitormattos modified the milestones: Next Major (30), Backlog Jun 10, 2024
@vitormattos vitormattos moved this from Next release to 0. Needs triage in Roadmap Jun 10, 2024
@vitormattos vitormattos added frontend Frontend task javascript Pull requests that update Javascript code labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature request frontend Frontend task javascript Pull requests that update Javascript code
Projects
Status: 0. Needs triage
Development

No branches or pull requests

2 participants