Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive calls of converter function when registering two message converters for same message type #382

Open
thomassedlmayer opened this issue Feb 20, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@thomassedlmayer
Copy link

I created a minimal extension that just registers two message converters for the same message (to SceneUpdate and FrameTransform):

https://github.com/thomassedlmayer/lichtblick-extension-bug-demo

This results in excessive calls of the converter function for various frames (see timestamps in console logs) of the dataset when loading an mcap file (and setting the topic on visible!). This can be seen in the Developer Tool Console.

I added an example mcap file in the same demo repo.

@thomassedlmayer thomassedlmayer added the bug Something isn't working label Feb 20, 2025
@jdsika
Copy link
Contributor

jdsika commented Feb 20, 2025

@laisspportugal this is a major problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants