Skip to content

tests: fix skipif condition for deepspeed #21195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 57 commits into from
Oct 23, 2025
Merged

tests: fix skipif condition for deepspeed #21195

merged 57 commits into from
Oct 23, 2025

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Sep 10, 2025 •
edited
Loading

What does this PR do?

seems it was falsely skipped, found while checking testing logs
required for #21194

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21195.org.readthedocs.build/en/21195/

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Sep 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 10, 2025 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success ✅

These checks are required after the changes to requirements/fabric/test.txt, src/lightning/fabric/utilities/testing/_runif.py, requirements/pytorch/test.txt, tests/tests_pytorch/strategies/test_deepspeed.py, tests/tests_pytorch/utilities/test_compile.py, tests/tests_pytorch/utilities/test_deepspeed_model_summary.py.

🟢 pytorch_lightning: lit GPU
Check ID Status
pytorch.yml / Lit Job (nvidia/cuda:12.1.1-devel-ubuntu22.04, pytorch, 3.10) success ✅
pytorch.yml / Lit Job (lightning, 3.12) success ✅
pytorch.yml / Lit Job (pytorch, 3.12) success ✅

These checks are required after the changes to .lightning/workflows/pytorch.yml, requirements/pytorch/test.txt, tests/tests_pytorch/strategies/test_deepspeed.py, tests/tests_pytorch/utilities/test_compile.py, tests/tests_pytorch/utilities/test_deepspeed_model_summary.py, requirements/fabric/test.txt, src/lightning/fabric/utilities/testing/_runif.py.

🟢 Benchmarks
Check ID Status
benchmark.yml / Lit Job (fabric) success ✅
benchmark.yml / Lit Job (pytorch) success ✅

These checks are required after the changes to requirements/fabric/test.txt, requirements/pytorch/test.txt, src/lightning/fabric/utilities/testing/_runif.py.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success ✅
docs-make (fabric, html) success ✅

These checks are required after the changes to src/lightning/fabric/utilities/testing/_runif.py, requirements/fabric/test.txt.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success ✅
docs-make (pytorch, html) success ✅

These checks are required after the changes to requirements/pytorch/test.txt.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu-guardian success ✅

These checks are required after the changes to requirements/fabric/test.txt, src/lightning/fabric/utilities/testing/_runif.py, tests/tests_fabric/strategies/test_deepspeed_integration.py.

🟢 lightning_fabric: lit GPU
Check ID Status
fabric.yml / Lit Job (nvidia/cuda:12.1.1-devel-ubuntu22.04, fabric, 3.10) success ✅
fabric.yml / Lit Job (fabric, 3.12) success ✅
fabric.yml / Lit Job (lightning, 3.12) success ✅

These checks are required after the changes to .lightning/workflows/fabric.yml, requirements/fabric/test.txt, src/lightning/fabric/utilities/testing/_runif.py, tests/tests_fabric/strategies/test_deepspeed_integration.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to requirements/fabric/test.txt, requirements/pytorch/test.txt, src/lightning/fabric/utilities/testing/_runif.py.

🟢 install
Check ID Status
install-pkg-guardian success ✅

These checks are required after the changes to src/lightning/fabric/utilities/testing/_runif.py, requirements/fabric/test.txt, requirements/pytorch/test.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 70 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov
Copy link

codecov bot commented Sep 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87%. Comparing base (6a8d943) to head (69cb738).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master   #21195    +/-   ##
========================================
- Coverage      87%      87%    -1%     
========================================
  Files         270      270            
  Lines       23801    23801            
========================================
- Hits        20773    20643   -130     
- Misses       3028     3158   +130

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 10, 2025
@github-actions github-actions bot added the ci Continuous Integration label Sep 10, 2025
bhimrazy
bhimrazy reviewed Sep 11, 2025
View reviewed changes
@SkafteNicki @bhimrazy
Apply suggestion from @bhimrazy
fa3e058 
Co-authored-by: Bhimraj Yadav <[email protected]>
SkafteNicki
SkafteNicki reviewed Sep 11, 2025
View reviewed changes
@deependujha
Copy link
Collaborator

deependujha commented Oct 17, 2025

the current failure doesn't seem to be due to deepspeed, but rather port still in use. Non-deterministic bug. We need to make sure port is available.

This was referenced Oct 18, 2025
Open
Open
@Borda Borda requested a review from deependujha October 21, 2025 09:08
@Borda Borda merged commit dd7b2f3 into master Oct 23, 2025
113 checks passed
@Borda Borda deleted the fix/skipif-deepspeed branch October 23, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton tchaton approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@deependujha deependujha deependujha approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@bhimrazy bhimrazy Awaiting requested review from bhimrazy

Assignees

No one assigned

Labels

ci Continuous Integration dependencies Pull requests that update a dependency file fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Borda @deependujha @tchaton @SkafteNicki @bhimrazy @ethanwharris @t-vi