Skip to content

Conversation

@bhimrazy
Copy link
Collaborator

@bhimrazy bhimrazy commented Nov 10, 2025

What does this PR do?

This PR adds PyTorch version 2.9 for CPU tests.

A follow-up PR (#21300) is already open to enable GPU tests.

Note: There appears to be a known issue on Windows since version 2.8
RuntimeError: makeDeviceForHostname(): unsupported gloo device
so tests had to be skipped for 2.9 as well.

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21352.org.readthedocs.build/en/21352/

@github-actions github-actions bot added the ci Continuous Integration label Nov 10, 2025
@bhimrazy bhimrazy changed the title test(ci): add pytorchversion 2.9 [wip] test(ci): add pytorchversion 2.9 Nov 10, 2025
@bhimrazy bhimrazy marked this pull request as ready for review November 10, 2025 06:48
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87%. Comparing base (b15d394) to head (a267ba5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21352   +/-   ##
=======================================
- Coverage      87%      87%   -0%     
=======================================
  Files         269      269           
  Lines       23744    23745    +1     
=======================================
- Hits        20572    20570    -2     
- Misses       3172     3175    +3     

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Nov 13, 2025
@bhimrazy bhimrazy changed the title [wip] test(ci): add pytorchversion 2.9 test(ci): add pytorch version 2.9 for CPU tests Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants