-
Notifications
You must be signed in to change notification settings - Fork 3.6k
test(ci): add pytorch version 2.9 for CPU tests
#21352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bhimrazy
wants to merge
4
commits into
Lightning-AI:master
Choose a base branch
from
bhimrazy:add/torch-2.9.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+13
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with new PyTorch versions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21352 +/- ##
=======================================
- Coverage 87% 87% -0%
=======================================
Files 269 269
Lines 23744 23745 +1
=======================================
- Hits 20572 20570 -2
- Misses 3172 3175 +3 |
4cb64ad to
b8ef64f
Compare
justusschock
approved these changes
Nov 12, 2025
…device` sems to be a known issue so ignoring foro 2.9 as well for windows
2.9 for CPU tests
deependujha
reviewed
Nov 14, 2025
deependujha
reviewed
Nov 14, 2025
deependujha
reviewed
Nov 14, 2025
deependujha
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds PyTorch version
2.9for CPU tests.Note: There appears to be a known issue on Windows since version
2.8—RuntimeError: makeDeviceForHostname(): unsupported gloo device—so tests had to be skipped for 2.9 as well.
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21352.org.readthedocs.build/en/21352/