Conversation
Borda
requested review from
ethanwharris,
justusschock and
tchaton
as code owners
for more information, see https://pre-commit.ci
3 tasks
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for the CLI functionality and fixes argument parsing to support both positional and optional argument styles. The changes ensure that CLI commands can be invoked with either style consistently.
- Adds parametrized tests to verify both positional and optional argument parsing for all CLI commands
- Modifies the CLI configuration to disable positional-only parsing by setting
as_positional=False - Improves test structure with helper methods for building commands and creating test files
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/unittests/cli/test_command_line.py | Adds comprehensive test suite with parametrized tests for both positional and optional argument styles |
| src/lightning_utilities/cli/main.py | Updates CLI configuration to support optional arguments by setting as_positional=False |
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Adding tests and fixing #371
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
📚 Documentation preview 📚: https://lit-utilities--420.org.readthedocs.build/en/420/