Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PS5 mask type problem #67

Open
ThisRock84 opened this issue Sep 5, 2024 · 5 comments
Open

PS5 mask type problem #67

ThisRock84 opened this issue Sep 5, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@ThisRock84
Copy link

ThisRock84 commented Sep 5, 2024

Hello,

While trying out the new etaHEN 1.8, I noticed that some patches work, while others show this issue: https://imgur.com/a/ihIB8X2

This might be due to illusion0001's new patch format, which uses Type="mask" instead of Type="bytes", but I'm not entirely sure.

All the patch files written as Mask are also problematic for me. Even when I change the mask text to something like AppVer='00.34', the patch still gives an error in the notification saying "waiting for eboot" and doesn't work.

How can I improve or fix this?

Original code
<Metadata Title="God of War Ragnarok"
Name="60 FPS"
Author="illusion"
PatchVer="1.0"
AppVer="mask"
AppElf="eboot.bin">
<PatchList>
<Line Type="mask" Address="e8 ?? ?? ?? ?? 8b 1d ?? ?? ?? ?? 48 8d bd 60 ff ff ff" Value="b800000000"/>
<Line Type="mask" Address="e8 ?? ?? ?? ?? 4c 8b 64 24 20 c5 f8 10 05 ?? ?? ?? ??" Value="b800000000"/>
<Line Type="mask" Address="e8 ?? ?? ?? ?? 8b 05 ?? ?? ?? ?? 89 c1 ff c1 c1 e9 1f 8d 4c 08 01 83 e1 fe f7 d9 8d 44 08 01" Value="b800000000"/>
</PatchList>
</Metadata>

Code after modify: https://ibb.co/q9NHqR7

Error: https://ibb.co/DKw0tzK

code that appears but does not work
<Metadata Title="God of War Ragnarok"
Name="60 FPS"
Author="illusion"
PatchVer="1.0"
AppVer="05.05"
AppElf="eboot.bin">
<PatchList>
<Line Type="mask" Address="e8 ?? ?? ?? ?? 8b 1d ?? ?? ?? ?? 48 8d bd 60 ff ff ff" Value="b800000000"/>
<Line Type="mask" Address="e8 ?? ?? ?? ?? 4c 8b 64 24 20 c5 f8 10 05 ?? ?? ?? ??" Value="b800000000"/>
<Line Type="mask" Address="e8 ?? ?? ?? ?? 8b 05 ?? ?? ?? ?? 89 c1 ff c1 c1 e9 1f 8d 4c 08 01 83 e1 fe f7 d9 8d 44 08 01" Value="b800000000"/>
</PatchList>
</Metadata>

@LightningMods
Copy link
Owner

Hello, yes currently the mask type is not supported however @illusion0001 said he will add support so I'll keep this issue open until it's added

@LightningMods LightningMods added the enhancement New feature or request label Sep 5, 2024
@ThisRock84
Copy link
Author

Thank you for your prompt response and for keeping the issue open. I appreciate the information and look forward to the support for the "mask" type being added in the future. Your efforts in improving etaHEN are greatly valued by the community!

@jackfavvv
Copy link

In the meantime, I've found a way to convert Type="mask" patches.

@jackfavvv
Copy link

Hello,

While trying out the new etaHEN 1.8, I noticed that some patches work, while others show this issue: https://imgur.com/a/ihIB8X2

This might be due to illusion0001's new patch format, which uses Type="mask" instead of Type="bytes", but I'm not entirely sure.

I Just noticed, but did you literally just copy & pasted that from a question that I asked awhile back? 0_o
That's definitely my image from FATAL FRAME: Mask of the Lunar Eclipse.

@ThisRock84
Copy link
Author

Hello,
While trying out the new etaHEN 1.8, I noticed that some patches work, while others show this issue: https://imgur.com/a/ihIB8X2
This might be due to illusion0001's new patch format, which uses Type="mask" instead of Type="bytes", but I'm not entirely sure.

I Just noticed, but did you literally just copy & pasted that from a question that I asked awhile back? 0_o That's definitely my image from FATAL FRAME: Mask of the Lunar Eclipse.

Absolutely! :) I combined the question you previously asked on Reddit with the work I've been doing, to create a single, comprehensive post for easier reference. The first image is part of your original post, while the others are from my own testing. Thank you for your keen observation, I appreciate the attention to detail!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants