Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temporaryImagePath could disappear before disk is unmounted #228

Open
osy opened this issue May 30, 2023 · 0 comments
Open

temporaryImagePath could disappear before disk is unmounted #228

osy opened this issue May 30, 2023 · 0 comments

Comments

@osy
Copy link

osy commented May 30, 2023

hdiutil detach does two things: 1. it will unmount the volume from /Volumes and 2. it will detach the disk image. Currently, appdmg will retry calling hdiutil detach when it fails. However, if it fails due to 2, then /Volumes/NAME as specified in temporaryImagePath will be gone. Then subsequent retries will fail as well. We are observing this happening on a slow filesystem where the writes are being flushed but the volume was able to be unmounted.

Suggestion: Use diskutil info /Volumes/NAME to get the Device Node and use the node name for hdiutil detach.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@osy