Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Day Time-based method #44

Open
quienn opened this issue Jan 4, 2024 · 1 comment
Open

Feature request: Day Time-based method #44

quienn opened this issue Jan 4, 2024 · 1 comment
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@quienn
Copy link
Contributor

quienn commented Jan 4, 2024

Right now when a user enables auto-dark-mode when there's no suitable platform detection method it errors out saying so.

For those users (like me, 'cause I'm using Termux and apparently I can't get the cmd uimode thing to work. 🤨), there should be a daytime method in which the user specifies her preferred interval, with custom auto-dark-daytime-(sunrise/sunset)-time variables.

This feature could potentially be useful for EXWM users too! And for them, there could also be a location method based on something like Geoclue, but that's out of the scope of this issue.

@LionyxML
Copy link
Owner

Hello there @quienn !

I think the way we implemented the error handling (if no method for switching is found) makes more damage than good by now, I might be changing it to "just a Waning on message buffer", thus avoiding Emacs loading issues.

That said, I'd prefer keeping the original functionality to the package, which is, "just follow the system theme settings".

The feature you described is nice, I just think it would not be the case to auto-dark to implement it.

A while ago someone contacted me to talk about this package: https://github.com/pedroangelo/theme-rotation.el from @pedroangelo.

I haven't tested it yet, but it looks nice, with some additions it might become what you just described.

@LionyxML LionyxML added enhancement New feature or request wontfix This will not be worked on labels Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants