refactor(widget): improve props handling, esp for templates #6319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjpalpha
reviewed
Aug 7, 2025
Comment on lines
+26
to
+28
| if Table.isNotEmpty(self.defaultProps) then | ||
| return self.defaultProps | ||
| end |
There was a problem hiding this comment.
imo add a comment that this handling is only legacy and deprecated
Comment on lines
+30
to
+31
| if prop.type == 'integer' then | ||
| args[propName] = WidgetFactory._parseInteger(args[propName]) |
There was a problem hiding this comment.
what about non integer numbers?
maybe
Suggested change
| if prop.type == 'integer' then | |
| args[propName] = WidgetFactory._parseInteger(args[propName]) | |
| if prop.type == 'integer' or prop.type == 'number' then | |
| args[propName] = WidgetFactory._parseNumber(args[propName]) |
Comment on lines
-14
to
+16
| ---@param args {widget: string, children: ((Widget|Html|string|number)[])|Widget|Html|string|number, [any]:any} | ||
| ---@param args {widget: string, children: any, [any]:any} |
There was a problem hiding this comment.
imo make a type alias for the original children type and use that
so something like Renderable = Widget|Html|string|number and make children of type Renderable|Renderable[]
There was a problem hiding this comment.
nice idea we could use it in some other places too :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Idea on improving the the Widget handling when it comes to props, default props, required props and coming from wikicode world where everything in a string.
How did you test this change?