ci: improve visual snapshot workflow setup time

[ElectricalBoy]

Summary

This PR removes installation step for playwright, replacing it with a prebuilt docker container.

References

• https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#example-using-a-docker-hub-action
• https://playwright.dev/docs/ci#docker

How did you test this change?

https://github.com/Liquipedia/Lua-Modules/actions/runs/17258627624/job/48975211664

[Rathoz]

Not sure I understand why this approach?

Why not just do the same as https://playwright.dev/docs/ci#docker, but with npm run lua-test instead of npx playwright test?

[ElectricalBoy]

Not sure I understand why this approach?

Why not just do the same as https://playwright.dev/docs/ci#docker, but with npm run lua-test instead of npx playwright test?

because mcr.microsoft.com/playwright:v1.55.0-noble does not include sudo, using our current lua setup action, and thus, running the entire workflow inside the container, is a no-go (unless we install sudo inside container before doing Lua stuff)

https://github.com/lewis6991/gh-actions-lua/blob/01aab24c4de9555717b685f9b142a2abbe12ef14/main.js#L223

[Rathoz]

Try going back to your oroginal attempt and do the following changes:

options: --user root in the container setup

      - name: Create a fake sudo wrapper
        run: |
          echo '#!/bin/sh' > /usr/local/bin/sudo
          echo 'exec "$@"' >> /usr/local/bin/sudo
          chmod +x /usr/local/bin/sudo

[ElectricalBoy]

Try going back to your oroginal attempt and do the following changes:

options: --user root in the container setup

      - name: Create a fake sudo wrapper
        run: |
          echo '#!/bin/sh' > /usr/local/bin/sudo
          echo 'exec "$@"' >> /usr/local/bin/sudo
          chmod +x /usr/local/bin/sudo

doesn't work either; 8df1fb5...a69a9e2

• all the build dependencies have to be installed from scratch (GH's runner images already have them loaded)
• apt-get does not have package list loaded (most containers don't anyway), so container needs to load them fresh
• the above two add enough complexity making this approach not preferable

[Rathoz]

If we fork gh-lua-acitons (it's dead anyway), if we remove the sudo, would it work?

[ElectricalBoy]

If we fork gh-lua-acitons (it's dead anyway), if we remove the sudo, would it work?

technically yeah, but at that point I think we should be prebuilding our own container image with lua installed instead