refactor: remove direct calls to mw.ext.teamtemplate #6624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjpalpha
reviewed
Oct 4, 2025
| substitutions = manualPlayersInput.substitutions | ||
| -- Change compared to commons MatchGroupInputUtil.readOpponent | ||
| local template = mw.ext.TeamTemplate.raw(opponent.template or '') or {} | ||
| local template = TeamTemplate.getRawOrNil(opponent.template or '') or {} |
There was a problem hiding this comment.
TeamTemplate.getRawOrNil expects a non-nil string argument
we could add nil handling there instead though
| function CustomPlayer:adjustLPDB(lpdbData, args) | ||
| if String.isNotEmpty(args.team2) then | ||
| lpdbData.extradata.team2 = mw.ext.TeamTemplate.raw(args.team2).page | ||
| lpdbData.extradata.team2 = TeamTemplate.getRaw(args.team2).page |
There was a problem hiding this comment.
why not use TeamTemplate.getPageName?
(same in several of the other cases too)
There was a problem hiding this comment.
getPageName has resolve_redirect slapped onto the return value, so not using it is to avoid breaking historic stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #6496
How did you test this change?
untested