Skip to content

Commit 32d5886

Browse files
authored
Make the extension compatible with MW 1.43 (#13)
1 parent b9ca460 commit 32d5886

File tree

3 files changed

+29
-17
lines changed

3 files changed

+29
-17
lines changed

extension.json

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ResourceLoaderArticles",
3-
"version": "2.4.0",
3+
"version": "2.5.0",
44
"author": [
55
"[https://fo-nttax.de Alex Winkler]"
66
],
@@ -27,7 +27,11 @@
2727
},
2828
"HookHandlers": {
2929
"Main": {
30-
"class": "\\Liquipedia\\Extension\\ResourceLoaderArticles\\Hooks\\MainHookHandler"
30+
"class": "\\Liquipedia\\Extension\\ResourceLoaderArticles\\Hooks\\MainHookHandler",
31+
"services": [
32+
"ContentHandlerFactory",
33+
"RevisionLookup"
34+
]
3135
},
3236
"Schema": {
3337
"class": "\\Liquipedia\\Extension\\ResourceLoaderArticles\\Hooks\\SchemaHookHandler"

src/Hooks/MainHookHandler.php

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,16 @@
22

33
namespace Liquipedia\Extension\ResourceLoaderArticles\Hooks;
44

5-
use ContentHandler;
65
use Liquipedia\Extension\ResourceLoaderArticles\ResourceLoader\ResourceLoaderArticlesModule;
6+
use MediaWiki\Content\ContentHandlerFactory;
77
use MediaWiki\Hook\BeforePageDisplayHook;
88
use MediaWiki\Hook\MakeGlobalVariablesScriptHook;
9-
use MediaWiki\MediaWikiServices;
109
use MediaWiki\ResourceLoader\Hook\ResourceLoaderRegisterModulesHook;
10+
use MediaWiki\ResourceLoader\ResourceLoader;
1111
use MediaWiki\Revision\Hook\ContentHandlerDefaultModelForHook;
1212
use MediaWiki\Revision\RevisionLookup;
1313
use MediaWiki\Revision\SlotRecord;
1414
use OutputPage;
15-
use ResourceLoader;
1615
use Skin;
1716
use Title;
1817

@@ -23,6 +22,17 @@ class MainHookHandler implements
2322
ResourceLoaderRegisterModulesHook
2423
{
2524

25+
private ContentHandlerFactory $contentHandlerFactory;
26+
private RevisionLookup $revisionLookup;
27+
28+
public function __construct(
29+
ContentHandlerFactory $contentHandlerFactory,
30+
RevisionLookup $revisionLookup
31+
) {
32+
$this->contentHandlerFactory = $contentHandlerFactory;
33+
$this->revisionLookup = $revisionLookup;
34+
}
35+
2636
/**
2737
* @param OutputPage $out
2838
* @param Skin $skin
@@ -135,17 +145,15 @@ public function onResourceLoaderRegisterModules( ResourceLoader $rl ): void {
135145
continue;
136146
}
137147

138-
$handler = ContentHandler::getForTitle( $title );
148+
$handler = $this->contentHandlerFactory->getContentHandler( $title->getContentModel() );
139149
if ( $handler->isSupportedFormat( CONTENT_FORMAT_CSS ) ) {
140150
$format = CONTENT_FORMAT_CSS;
141151
} elseif ( $handler->isSupportedFormat( CONTENT_FORMAT_JAVASCRIPT ) ) {
142152
$format = CONTENT_FORMAT_JAVASCRIPT;
143153
} else {
144154
continue;
145155
}
146-
$revision = MediaWikiServices::getInstance()
147-
->getRevisionLookup()
148-
->getRevisionByTitle( $title, 0, RevisionLookup::READ_NORMAL );
156+
$revision = $this->revisionLookup->getRevisionByTitle( $title, 0, RevisionLookup::READ_NORMAL );
149157

150158
if ( !$revision ) {
151159
continue;

src/ResourceLoader/ResourceLoaderArticlesModule.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,25 +10,25 @@
1010
use Less_Parser;
1111
use MediaWiki\MainConfigNames;
1212
use MediaWiki\MediaWikiServices;
13+
use MediaWiki\ResourceLoader\Context;
14+
use MediaWiki\ResourceLoader\ResourceLoader;
15+
use MediaWiki\ResourceLoader\WikiModule;
1316
use MemoizedCallable;
1417
use Peast\Peast;
1518
use Peast\Syntax\Exception as PeastSyntaxException;
16-
use ResourceLoader;
17-
use ResourceLoaderContext;
18-
use ResourceLoaderWikiModule;
1919
use ScssPhp\ScssPhp\Compiler as SCSSCompiler;
2020

21-
class ResourceLoaderArticlesModule extends ResourceLoaderWikiModule {
21+
class ResourceLoaderArticlesModule extends WikiModule {
2222

2323
private const USERJSPARSE_CACHE_VERSION = 3;
2424

2525
/**
2626
* Get list of pages used by this module
2727
*
28-
* @param ResourceLoaderContext $context
28+
* @param Context $context
2929
* @return array List of pages
3030
*/
31-
protected function getPages( ResourceLoaderContext $context ) {
31+
protected function getPages( Context $context ) {
3232
$request = $context->getRequest();
3333
$articles = $request->getVal( 'articles' );
3434
$articles = explode( '|', $articles ?? '' );
@@ -100,10 +100,10 @@ static function () use ( $contents, $fileName ) {
100100
}
101101

102102
/**
103-
* @param ResourceLoaderContext $context
103+
* @param Context $context
104104
* @return array
105105
*/
106-
public function getStyles( ResourceLoaderContext $context ) {
106+
public function getStyles( Context $context ) {
107107
$less = '';
108108
$scss = '';
109109
foreach ( $this->getPages( $context ) as $titleText => $options ) {

0 commit comments

Comments
 (0)