Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading splits from the Leaderboard should act as new splits #362

Open
CryZe opened this issue May 3, 2020 · 2 comments · May be fixed by #363
Open

Downloading splits from the Leaderboard should act as new splits #362

CryZe opened this issue May 3, 2020 · 2 comments · May be fixed by #363
Labels
bug There's a bug in LiveSplit One. suitable for contributions An issue that is suitable to tackle for someone new to the repository. UI The issue is about the user interface.

Comments

@CryZe
Copy link
Collaborator

CryZe commented May 3, 2020

If you download splits from the leaderboard in the Run Editor, it'll override the run that is getting modified by the run editor. However if you save that, there's two possible suboptimal behaviors:

  1. If you edited the splits that you had open in your timer, it'll correctly replace the splits in the timer. However it will not reset your splits key. So the splits will still be associated to your splits and those will be overridden once you save. The downloaded splits should be regarded as fresh splits (splits key == undefined).

  2. If you edit splits in your database and exit the run editor with the downloaded splits, then the splits in the database will be overridden, which you likely didn't intend to do. We should create a new entry in the database.

@CryZe CryZe added bug There's a bug in LiveSplit One. suitable for contributions An issue that is suitable to tackle for someone new to the repository. labels May 3, 2020
@wooferzfg
Copy link
Member

wooferzfg commented May 3, 2020

We should probably fix this too in the process of fixing this issue:

// TODO Oh no, not internal pointer stuff

@wooferzfg
Copy link
Member

Another issue is that downloading splits from the leaderboard doesn't prompt you about unsaved changes.

@wooferzfg wooferzfg linked a pull request May 12, 2020 that will close this issue
@wooferzfg wooferzfg added the UI The issue is about the user interface. label May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug There's a bug in LiveSplit One. suitable for contributions An issue that is suitable to tackle for someone new to the repository. UI The issue is about the user interface.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants