Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add means of converting coordinates in Gazetteer.Place for geom field #141

Open
5 tasks
griff-rees opened this issue Jul 19, 2023 · 0 comments
Open
5 tasks
Labels
enhancement New feature or request

Comments

@griff-rees
Copy link
Collaborator

All the Gazetteer models have geom fields. In the current configuration of alto2txt2fixture.create_adjacent_tables json and csv results, Place includes longitude and latitude fields. These can be combined into a geom field when imported into Gazetteer.Place.

Tasks:

  • Check if there is any advantage in implementing this within alto2txt2fixture (reason not is requiring geopandas...)
  • Add as a func within lwmdb.utils to convert those fields into a GeometryCollection
  • Include a way to check the srid
  • Add basic doctest for that func independent of Gazetteer.Place (for example see the download_file docstring which auto renders and is included in pytest)
  • Add a method on func to add these and a test within gazetteer.tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants