Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise code, update project structure/configs/gradle files #33

Open
livotov opened this issue Dec 11, 2020 · 2 comments
Open

Revise code, update project structure/configs/gradle files #33

livotov opened this issue Dec 11, 2020 · 2 comments
Assignees

Comments

@livotov
Copy link
Member

livotov commented Dec 11, 2020

No description provided.

@livotov livotov self-assigned this Dec 11, 2020
@mezpahlan
Copy link
Contributor

Hi @livotov in a previous PR I bumped the Android Gradle Plugin version to 4.2.0-alpha16 and now looking back I don't think I should have done that without discussing with you first. The reason I did that is because I use the canary build of Android Studio at home and it suggested that I update the plugin to the canary version.

However I realise two things:

  1. The canary version updates all the time meaning I'm having to update the version in each PR I open. Often this change is unrelated to the change in the PR so is a distraction.
  2. This forces other contributors (and yourself) to use the canary version of Android Studio which unless that is also your project decision is probably not something I should have decided on my own.

The good news is that if I set the Android Gradle Plugin back to the latest stable, my canary version of Android Studio no longer complains. This also means that everyone else wanting to contribute can continue to use their preferred version of Android Studio knowing that the project dependencies are stable.

Hopefully that makes sense. I'll raise a PR shortly to lower it.

@livotov
Copy link
Member Author

livotov commented Dec 28, 2020

Thanks, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants