Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API leakage with the on-open action #8

Open
cantsin opened this issue Feb 22, 2016 · 2 comments
Open

API leakage with the on-open action #8

cantsin opened this issue Feb 22, 2016 · 2 comments

Comments

@cantsin
Copy link
Contributor

cantsin commented Feb 22, 2016

With the new on-open action, we inadvertently leak some internals to outside, specifically our openNodes list which contains Node classes. I'm not yet sure how to address this.
@taras
Copy link
Contributor

taras commented Feb 22, 2016

It might also be ok! Especially, if it's possible for a Node to be extended. I'm not 100% on this. I can ask around.

@taras
Copy link
Contributor

taras commented Feb 22, 2016

Here is an example of using ES6 classes to provide an interface https://github.com/flexyford/impagination

@cantsin cantsin mentioned this issue Mar 21, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@taras @cantsin