-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
area chart demo #10
Comments
This would be a great help. I'm struggling with how to pass in context to be able to lookup the x,y scale functions to d3-shape.area In my template I have my scales defined using ember-d3-helpers
and I have the area function defined in the component
But of course x and y are undefined inside the area function. |
Hi @mrosenberg I was just looking at this today. I can take a crack at it tomorrow unless @zigahertz or @guozhaonan gets to it first. |
@mrosenberg can you give me a link to a D3 demo that you're referencing? |
@taras That would be appreciated by myself and I'm sure many others. I can't link to the app I'm working on but I may be able to post a pen later. Of course right after I wrote that post I thought of an idea that may work. I'm writing an area helper similar to the bar-height helper in the bar chart demo. |
@mrosenberg the area helper is what I was thinking is necessary. |
@taras As usual I think of something right after posting. If I get it working I'll write back here, maybe I can contribute it back to the demo. |
@mrosenberg sounds great and we could pull your helper into ember-d3-helpers if you get it working |
@taras Sounds like a plan. |
@taras I have a basic area chart up and running. I'm going to fork ember-d3-helpers and write up a demo there then publish a PR if that is OK with you. |
Sounds great to me |
@mrosenberg just FYI, we have a change coming to |
@taras I read that yesterday. Any eta on the change? I'll merge from upstream after that lands and write the example then. |
The PR is in the ember-d3-helpers repo. Have a look(sorry, can't link, on phone) we should be merging it soon. |
@mrosenberg just merged the PR that @taras is talking about, and published a new version of |
@mrosenberg I submitted a PR to your |
No description provided.
The text was updated successfully, but these errors were encountered: