Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix too late transition error #7

Open
ghost opened this issue Jun 28, 2016 · 1 comment
Open

fix too late transition error #7

ghost opened this issue Jun 28, 2016 · 1 comment

Comments

@ghost
Copy link

ghost commented Jun 28, 2016

when you click around very fast, a console error happens - need to look into this

@ghost ghost changed the title fix transitions fix too late transition error Jun 28, 2016
@taras
Copy link
Contributor

taras commented Jul 25, 2016

I put some effort into trying to figure this out. It's not a trivial problem and it's not clear how to solve it. This problem occurs when you trigger a transition while there is one in progress. It also, seems to only happen when you're in the later stage of the transition.

I changed the demos to throttle data change to only cause data change after transition is finished. I explicitly specified throttle delay to match transition duration + 20ms. This seams to work reliably enough. It's an ok solution for now but we need a better solution long term.

It would be excellent if we could use an ember-concurrency task with a transition. This wold allow us to programmatically cancel and restart transitions. What this looks like exactly, I'm not sure. It'd be a fun experiment for someone who's interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant