Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden, but syntactically incorrect links inserted to issue and PR descriptions (OSOE-750) #294

Closed
BenedekFarkas opened this issue Dec 5, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@BenedekFarkas
Copy link
Member

BenedekFarkas commented Dec 5, 2023

I noticed this under multiple PRs of my own issue and found other cases too: Something that resembles a regular issue link in MD format is inserted into PR descriptions (even if it already has a correct issue link), but it's not a complete link and isn't rendered. Might be down to a breaking change by Atlassian when supplying the link to an issue through the issue API.
We should also get rid of the tracking query string.

Example description source:

[OSOE-743](https://lombiq.atlassian.net/browse/OSOE-743)

[OSOE-743]: https://lombiq.atlassian.net/browse/OSOE-743?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Example PRs:

Jira issue

@BenedekFarkas BenedekFarkas added the bug Something isn't working label Dec 5, 2023
@github-actions github-actions bot changed the title Hidden, but syntactically incorrect links inserted by probably Update-GitHubIssueAndPullRequest Hidden, but syntactically incorrect links inserted by probably Update-GitHubIssueAndPullRequest (OSOE-750) Dec 5, 2023
@Piedone
Copy link
Member

Piedone commented Dec 5, 2023

I think this is rather some strange bug in the GH editor. The hidden links might at one point be added by our workflows, but at least they're re-added by GH without any workflows running:

2023-12-05_21h16_33.mp4

Or, perhaps they're added by GH for some reason to begin with. Maybe some clash between the explicitly added [OSOE-743](https://lombiq.atlassian.net/browse/OSOE-743) link and autolinks.

@BenedekFarkas
Copy link
Member Author

@BenedekFarkas BenedekFarkas changed the title Hidden, but syntactically incorrect links inserted by probably Update-GitHubIssueAndPullRequest (OSOE-750) Hidden, but syntactically incorrect links inserted to issue and PR descriptions (OSOE-750) Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants