fix: add remove cookie options

Author: MatthewPattell

__tests__/services/abstract-microservice-test.ts

@@ -8,7 +8,8 @@ import BaseException from '@core/base-exception';
 import MicroserviceRequest from '@core/microservice-request';
 import MicroserviceResponse from '@core/microservice-response';
 import ConsoleLog from '@drivers/console-log';
-import { MiddlewareHandler, MiddlewareType } from '@interfaces/services/i-abstract-microservice';
+import type { MiddlewareHandler } from '@interfaces/services/i-abstract-microservice';
+import { MiddlewareType } from '@interfaces/services/i-abstract-microservice';
 import AbstractMicroservice from '@services/abstract-microservice';
 import Microservice from '@services/microservice';
 

__tests__/services/gateway-test.ts

@@ -1,15 +1,16 @@
-import { Server } from 'http';
+import type { Server } from 'http';
 import axios from 'axios';
 import { expect } from 'chai';
-import { Response } from 'express';
+import type { Response } from 'express';
 import _ from 'lodash';
 import type { SinonStub } from 'sinon';
 import sinon from 'sinon';
 import { EXCEPTION_CODE } from '@constants/index';
 import MicroserviceResponse from '@core/microservice-response';
 import { CookiesAction } from '@interfaces/core/i-microservice-response';
-import { MiddlewareHandler, MiddlewareType } from '@interfaces/services/i-abstract-microservice';
-import { IExpressRequest } from '@interfaces/services/i-gateway';
+import type { MiddlewareHandler } from '@interfaces/services/i-abstract-microservice';
+import { MiddlewareType } from '@interfaces/services/i-abstract-microservice';
+import type { IExpressRequest } from '@interfaces/services/i-gateway';
 import AbstractMicroservice from '@services/abstract-microservice';
 import Gateway from '@services/gateway';
 
@@ -407,7 +408,7 @@ describe('services/gateway', () => {
               value: 'test1',
               options: { httpOnly: true },
             },
-            { action: CookiesAction.remove, name: 'cookie2' },
+            { action: CookiesAction.remove, name: 'cookie2', options: { domain: 'test' } },
           ],
         },
       },
@@ -423,7 +424,12 @@ describe('services/gateway', () => {
     const result = res.json.firstCall.firstArg;
 
     expect(addCookie).to.deep.equal(['cookie1', 'test1', { httpOnly: true }]);
-    expect(clearCookie).to.deep.equal(['cookie2']);
+    expect(clearCookie).to.deep.equal([
+      'cookie2',
+      {
+        domain: 'test',
+      },
+    ]);
     expect(result.payload).to.undefined;
   });
 });

src/services/abstract-microservice.ts

@@ -369,6 +369,8 @@ abstract class AbstractMicroservice {
     } catch (e) {
       // Could not connect to ijson or channel
       if (e.message === 'socket hang up' || e.message.includes('ECONNREFUSED')) {
+        this.logDriver(() => `Worker shutdown: ${e.message as string}`, LogType.ERROR);
+
         throw e;
       }
 

src/services/gateway.ts

@@ -253,12 +253,14 @@ class Gateway extends AbstractMicroservice {
         _.unset(reqPayload, 'cookies');
 
         cookies.forEach((cookie) => {
-          switch (cookie.action) {
+          const { action, name, value, options } = cookie;
+
+          switch (action) {
             case 'add':
-              res.cookie(cookie.name, cookie.value, cookie.options ?? {});
+              res.cookie(name, value, options ?? {});
               break;
             case 'remove':
-              res.clearCookie(cookie.name);
+              res.clearCookie(name, options ?? {});
           }
         });
       }