Issue with the Defines VICTORY_DOMINATION_CONTROL_PERCENT rounding up/down

[danielsolaro]

*I'm not sure I should report this here, as its irrelevant for base VP currently. It affects modmods.

1. Mod Version (X.Y.Z). Current Version: 4.15.2 with EUI and NO 43civ

3. List of Other Mods
All in the rar https://www.mediafire.com/file/jldr6vrrknk17q4/MODS.rar/file

4. Describe the Issue
With the VICTORY_DOMINATION_CONTROL_PERCENT set to 75, I needed 13.5 capitals out of 18. The victory screen asks me to have 14 but victory triggers on conquering the 13th capital (in my case was Istanbul). I assume its just the UI rounding up and the victory trigger checking for a rounded down number, maybe something else that coincidentally resulted in this.
I hope its something simple to fix.
quick: I truly believe this percent should change with map size, as domination seems to scale harder with map size than other win conditions.

---

5. Save Game From 1 Turn Before (ALWAYS ATTACH THIS IF POSSIBLE)
included with the mods

8. Steps to reproduce the Issue (Optional)
Open the victory screen

9. Screenshots of the Issue (Optional)

[azum4roll]

Do you have a vassal?

[danielsolaro]

A few. I got their capitals before accepting capitulation but iirc they count on the victory screen even when they still have their capitals, no? I will try to load my save again, not on pc right now

…

________________________________ From: azum4roll ***@***.***> Sent: Thursday, September 5, 2024 4:02 AM To: LoneGazebo/Community-Patch-DLL ***@***.***> Cc: danielsolaro ***@***.***>; Author ***@***.***> Subject: Re: [LoneGazebo/Community-Patch-DLL] Issue with the Defines VICTORY_DOMINATION_CONTROL_PERCENT rounding up/down (Issue #11265) Do you have a vassal? — Reply to this email directly, view it on GitHub<#11265 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACA7GAN4ZTNPBFQLLLGFCZDZU7JWRAVCNFSM6AAAAABNVAR3USVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZQGU2TAOJXHE>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[danielsolaro]

Do you have a vassal?

finally on pc, opened the game and yes I have all my vassal capitals. I will post two screenshots, please forgive me I had updated my mod to require 80% of the capitals for a new game so its asking for +2 instead of +1 like when I reported the bug.

[RecursiveVision]

@TechpriestEnginseer Any thoughts?

[danielsolaro]

just to confirm I finished another game - with a different amount of civs - and the same thing happened