Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse $VSS in padding area #184

Open
lzp729 opened this issue Sep 6, 2019 · 4 comments
Open

Parse $VSS in padding area #184

lzp729 opened this issue Sep 6, 2019 · 4 comments

Comments

@lzp729
Copy link

lzp729 commented Sep 6, 2019

With AMD BIOS built with Insyde EDKII, a group of var stores is in the padding area immediately after FV NVRam, please enhanced the RawAreaPaser function.

@NikolajSchlej
Copy link
Collaborator

Please attach a sample file.

@lzp729
Copy link
Author

lzp729 commented Sep 6, 2019

gh2.zip

uploaded, for some NDA reasons, I have removed most DXE and PEI drivers, but still enough to show the $vss in Padding
Fixed: Yes
Base: 63B000h
Address: FFE3B000h
Offset: 63B000h
Full size: 45000h (282624)

@lzp729
Copy link
Author

lzp729 commented Sep 6, 2019

and also, please note

Fixed: Yes
Base: 60B048h
Address: FFE0B048h
Offset: 48h
Full size: 15FB8h (90040)

which caused an error msg with new engine

findNextStore: VSS store candidate at offset 48h skipped, has invalid size FFFFFFFFh.
Insyde EDKII use the area as BIOS setting storage, FFFFFFFFh means it's empty, should not be an error.


for the error msg

parseVolumeHeader: unaligned volume
I can see that with full BIOS binary just like the reduced one, yet have not look into that

@NikolajSchlej
Copy link
Collaborator

NikolajSchlej commented Sep 6, 2019

should not be an error.

It is not an error, but an informational status message that might or might not indicate an error. This is extremely useful in catching empty volumes that aren't supposed to be empty, and I'll leave it as is because of that.

@NikolajSchlej NikolajSchlej changed the title [Enhancement Req][NE][FFSParser][parseRawArea] parse $VSS in padding aera [Engine] Parse $VSS in padding area Jan 25, 2020
@NikolajSchlej NikolajSchlej changed the title [Engine] Parse $VSS in padding area Parse $VSS in padding area Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants