Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datetime format used in version string incompatible with RPM package names #39

Open
waynr opened this issue Oct 1, 2014 · 1 comment
Assignees

Comments

@waynr
Copy link

waynr commented Oct 1, 2014

Our internal packaging tool for puppet-server uses the Maven artifact version to indicate package versions.

We are considering the use of lein-voom to track internal development versions of puppet-server to avoid inconsistent jumps [edit: in version string, ie 0.2.1 to 0.2.5 to 0.2.7] between publicly-released maven artifacts and OS packages. However, my initial trials of lein voom have revealed that the datetime format used in its version strings is incompatible with RPM package naming conventions due to the use of understore in `YYYYMMDD_HHmm".

Two different approaches that we believe would address this issue include:

  • Replace the underscore with a 'T' such that the datetime portion of the version string would be formatted as such: YYYYMMDD_HHmm
  • Provide the ability to specify lein-voom version string format in project.clj such that users of lein-voom could use a standard datetime format string with an additional formatting option to add in a long or short git sha if they wish. The default without this format string specified in project.clj would be the same as it is currently.

I am personally partial to the second approach. If this issue is approved by the core developer(s) I will research available clojure datetime string formatting libraries and submit a PR ASAP.

@abrooks
Copy link
Member

abrooks commented Oct 2, 2014

I think your assessment in #40 is probably right though there might be some wiggle room, via the metadata. I'll think about it but won't promise anything. Version strings are forever and the primary compatability, communication point.

We have heard of issues with some artifact repositories not taking these strings as well even though, they are fully compliant with the Maven version spec and implementation.

I'm always happy to hear suggestions.

@abrooks abrooks self-assigned this Oct 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants