Fix dev repl classpath #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* :dev profile dep on leiningen-core "2.5.1" * :clojure-1.5 dep on clojure 1.5.0 * :clojure-1.6 dep on clojure 1.6.0 Before this change, project.clj does not depend directly on everything necessary to start a REPL. 'lein repl' pulls in all of leiningen's own dependencies and therefore works, but the following does not: $ java -cp `lein classpath` clojure.main -r Clojure 1.2.0 ; <--- note clojure version! user=> (require 'leiningen.voom) ;; ...error message related to missing clojure.edn With these new profiles, the following succeeds: $ java -cp `lein with-profile dev,clojure-1.5 classpath` clojure.main -r This issue only affects lein-voom development itself, so relegating these dependencies to these profiles should be sufficient.
This removes the dependency on leiningen-core "2.5.1" from the :dev profile and puts it in its own :leiningen-core-2.5.1 profile. In contrast to :dev, the :leiningen-core-2.5.1 profile must be requested explicitly, so that (for example) 'lein repl' will work in the future without manually specifying a new version of leiningen-core in the :dev profile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following dependencies via profiles:
Before this change, project.clj does not depend directly on everything necessary to start a REPL. 'lein repl' pulls in all of leiningen's own dependencies and therefore works, but the following does not:
$ java -cplein classpathclojure.main -rClojure 1.2.0 ; <--- note clojure version!user=> (require 'leiningen.voom);; ...error message related to missing clojure.ednWith these new profiles, the following succeeds:
$ java -cplein with-profile leiningen-core-2.5.1,clojure-1.5 classpathclojure.main -rThis issue only affects lein-voom development itself, so relegating these dependencies to these profiles should be sufficient.