[Feature]: recoil

[ShadowKnight0009]

Confirmations

• There isn't any other PR or issue regarding this.
• This feature does not exist in the latest version.

What is your request about?

New gun

Description

you should add 0.75 0.50 and 0.25 recoil because 0 is a very small amount and 1 is too high

[micxudev]

Recoil field is of type double, so you can use any value: 0.25, 0.5, 0.75 etc.

[ShadowKnight0009]

Well last time I remembered trying it on the ak 47 and it did not work

[WhatYouTalkinAbout]

This is actually a problem with programming in java itself: any type of double variable like 0.25 or 1/2 cannot be casted into an integer because of how java and pretty much how all computers handle variables with decimals. The main point is that recoil requires an integer value as a parameter so any double value inserted will try to cast into an integer which will throw an exception.

[micxudev]

The main point is that recoil requires an integer value

Can you me the place please where recoil is used as an Integer?

[WhatYouTalkinAbout]

Actually I figured something out, the problem is not the code, it's because JSON doesn't recognize double as a type and instead it's called number as well as some other things. I suggest reading this to know more about it: https://json-schema.org/understanding-json-schema/reference/numeric JSON uses the type number to represent non-integer numbers like 3.2 or 1.5 the problem is trying to cast it into a double value when being read by Java code. Another problem is that if you have a JSON value like 1.0 the type is still an Integer because it is a whole number. This is a big problem when trying to get JSON values using org.json.jsonObject.getDouble() (ironic as it is actually called number in JSON) as the value is still an integer and not a double. And you can't have a variable be both of type Integer and of type Double at the same time. I will keep researching this issue in case I find anything else.

[Lorenzo0111]

I'm not using JSON but YAML for configurations and I think the recoil has been changed to double recently. Did you try with the latest dev build?

[ShadowKnight0009]

Yes I do have the latest dev build I think the recoil is unrealistic because if you hold a gun in the correct way it shouldn't have that much recoil.

[Lorenzo0111]

You can configure it in the way you want by changing the gun configuration file

[itsLolo364]

I'm doing a fork that adds this and many other similar things, of you are interested i'm gonna commit It in some hours on my profile as a fork

[Lorenzo0111]

Feel free to open a PR if you want to add these features into QA