Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use request cancellationtoken #280

Open
Poltuu opened this issue Nov 16, 2018 · 3 comments
Open

use request cancellationtoken #280

Poltuu opened this issue Nov 16, 2018 · 3 comments

Comments

@Poltuu
Copy link
Contributor

Poltuu commented Nov 16, 2018

It is very important to handle browser refresh/closing properly, and is pretty easy to do.
This can be done with a mvc filter + passing the cancellationtoken from top to bottom.

This is a massive API breaking change thus, as basically every XXXAsync API needs to be patched, but I believe is a very important change

@nfaugout-lucca
Copy link
Contributor

SemVer + breaking change = Label v4 ;)

@rducom
Copy link
Contributor

rducom commented Nov 16, 2018

No need of a filter, MVC inject cancellation tokens in action method parameters

@Poltuu
Copy link
Contributor Author

Poltuu commented Nov 19, 2018

filter is not for token injection, but for proper handling of OperationCanceledException

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants