Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic :LvimCacheReset when lvim.lsp.automatic_configuration.skipped_servers changes #4205

Open
ReallySnazzy opened this issue May 26, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@ReallySnazzy
Copy link
Contributor

Feature Description

If lvim.lsp.automatic_configuration.skipped_servers changes, then automatically perform :LvimCacheReset / require("lvim.utils.hooks").reset_cache(). I got a bit confused while trying to work out how to switch tsserver to denols. I ran it after adding tsserver to skipped, but I didn't after removing denols from skipped and was having issues troubleshooting. It seems like it might not be a bad idea to have LunarVim automatically do this since it would mean less user error and doesn't seem like a big change maybe?

Describe the alternatives you have considered

I thought about adding it to my own config, but it would be nice to have built into Lunarvim

Support information

No response

@ReallySnazzy ReallySnazzy added the enhancement New feature or request label May 26, 2023
@LostNeophyte
Copy link
Member

how would we detect that change? unless this feature would only work with :LvimReload

@ReallySnazzy
Copy link
Contributor Author

ReallySnazzy commented Jun 7, 2023

Could save a file containing the last state of that list and then when neovim is loaded if lvim can detect that the current state of the list is different from the file, it could perform the cache cleaning logic.

@LostNeophyte
Copy link
Member

I think that the current lsp config is quite confusing for the users and I want to change it either way. I plan to remove the need for this template generation after each change of the config completely. I'd need to experiment and find a way to organize the config that I think is better, then consult the other team members and users. That process is time consuming though so I'm fine with using a file in cache as a temporary solution
this is my personal opinion though, I'm not sure what other members think about it

@kylo252 kylo252 self-assigned this Jun 17, 2023
@kylo252
Copy link
Collaborator

kylo252 commented Jun 17, 2023

Could save a file containing the last state of that list and then when neovim is loaded if lvim can detect that the current state of the list is different from the file, it could perform the cache cleaning logic.

@ReallySnazzy, that should be doable! We just need to make sure it's cheap/fast to do this validation, since it needs to be done every time you load the config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants