Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in sammyuri's Minecraft in Minecraft #125

Open
ghost opened this issue Aug 19, 2023 · 4 comments
Open

Regression in sammyuri's Minecraft in Minecraft #125

ghost opened this issue Aug 19, 2023 · 4 comments

Comments

@ghost
Copy link

ghost commented Aug 19, 2023

766301d

git checkout 766301de9906ab0c743695446ee2104791e75102 . 

Everything works:
works

57a650b

git checkout 57a650b273c674e13f5de82c12d8e38b7c6acb31 .

Rendering is broken, the camera can still move though:

broken

Edit: to clarify, it is broken since then, even in the latest commit

Edit 2: simply reverting the commit does nothing, the problem is somewhere else, sorry for the confusion

Edit 3: c3bc9f5 is the last (?) that really works. This time I didn't forget to use git reset --hard

@ghost ghost changed the title Regression in sammyuri's Minecraft in Minecraft after "Fix Chungus benchmark" Regression in sammyuri's Minecraft in Minecraft Aug 24, 2023
@BramOtte
Copy link
Contributor

BramOtte commented Dec 2, 2023

I do not know how I haven't noticed this regressing before but I just got a similar issue with the chungus2 mandlebrot benchmark which seams to have started at the exact same point in git history.
Since it took so long to spot I fear rust changed something in the compiler or our testing has simply not been thorough enough.
The commit where everything seams to break is described as a fix, assuming this is not some weird change in the rust compiler, I wonder if chungus2 needs that bug to function or if it was not implemented correctly.
If the commit that broke chungus2 does work as intended it might be best to just have some configuration flag to compile mchprs to work with chungus2 or chungus2 itself can be fixed.

@StackDoubleFlow
Copy link
Member

I'm fairly certain the problem is in the screen hardware that might depend on a specific mchprs inaccuracy with repeater updates that has now been fixed (I'm assuming this is the commit you're talking about). I don't intend on having a configuration flag to work around this, so the redstone will also have to be fixed.

@ghost
Copy link
Author

ghost commented Jan 2, 2024

I don't intend on having a configuration flag to work around this, so the redstone will also have to be fixed.

Could you please reconsider this? That's probably the greatest redstone build out there, it would be nice if it continued to work on the most recent versions of MCHPRS with all the new improvements. It would even be ok for me if the configuration flag had to be set before compilation

@IUM259
Copy link

IUM259 commented Jun 20, 2024

One problem that MiM has is the multipliers, there are several in AMOGUS GPU, please check this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants