Tweak the plot update loop #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paul1365972
force-pushed
the
tweak_update_loop
branch
from
9516728
to
3f4c56c
Compare
|
I have since reverted the maximum tick batch size back to 50_000 after realizing that we actually send world updates 60, not 20, times per second. |
Paul1365972
force-pushed
the
tweak_update_loop
branch
from
3f4c56c
to
e1d6c8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this PR mostly to improve the interaction between the update loop and future new backends.
Some nice side effects are that when the redpiler is reset it will no longer hang or even timeout the player in extreme cases.
This also nearly solves the issue where changes would not flush at a consistent rate at very high tick rates.
The auto redpiler feature should also work more consistently now.
I additionally changed some of the magic constants, the new values worked better for my use cases, but I would still like a second opinion on them (Especially the reduction of the max batch size to 15_000 per update, does that create any issues?).