From 73c6c062e431364475811b2446865bf98b84d1e6 Mon Sep 17 00:00:00 2001 From: Rocco Meli Date: Sun, 22 Dec 2024 23:08:46 +0100 Subject: [PATCH 1/3] update --- .github/PULL_REQUEST_TEMPLATE.md | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f6aeb1f0eb1..59675a64629 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,15 +1,12 @@ -Fixes # +Fixes # Changes made in this Pull Request: - - + - PR Checklist ------------ - - [ ] Tests? - - [ ] Docs? + - [ ] Tests added? + - [ ] Documentation updated? - [ ] CHANGELOG updated? - [ ] Issue raised/referenced? - -## Developers certificate of origin -- [ ] I certify that this contribution is covered by the LGPLv2.1+ license as defined in our [LICENSE](https://github.com/MDAnalysis/mdanalysis/blob/develop/LICENSE) and adheres to the [**Developer Certificate of Origin**](https://developercertificate.org/). From d5fef31a4376b3488dea7cdaa4b54ec363dfdf9b Mon Sep 17 00:00:00 2001 From: Rocco Meli Date: Wed, 8 Jan 2025 22:28:05 +0100 Subject: [PATCH 2/3] improvements --- .github/PULL_REQUEST_TEMPLATE.md | 32 ++++++++++++++++++++++++-------- 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 59675a64629..a4442fe6291 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,12 +1,28 @@ -Fixes # + +Fixes # Changes made in this Pull Request: - - + +- - -PR Checklist ------------- - - [ ] Tests added? - - [ ] Documentation updated? - - [ ] CHANGELOG updated? +## PR Checklist + - [ ] Issue raised/referenced? + - [ ] Tests updated/added? + - [ ] Documentation updated/added? + - [ ] `package/CHANGELOG` file updated? + - [ ] Is your name in `package/AUTHORS`? (If it is not, add it!) + +## Developers Certificate of Origin + + +In order for this PR to be merged you **must certify that you are able to submit your code to be included in MDAnalysis**. Read the links and then check the box if you agree. + +Code in MDAnalysis is under [LICENSE](https://github.com/MDAnalysis/mdanalysis/blob/develop/LICENSE). + +- [ ] I certify that I can legally submit this code contribution as described in the [**Developer Certificate of Origin**](https://developercertificate.org/) From 40e797b92f84762f8c1e970ff90b3e7b52e240f6 Mon Sep 17 00:00:00 2001 From: Rocco Meli Date: Sun, 26 Jan 2025 21:46:34 +0100 Subject: [PATCH 3/3] ialibay comments --- .github/PULL_REQUEST_TEMPLATE.md | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a4442fe6291..86e356f263f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -18,11 +18,7 @@ Changes made in this Pull Request: ## Developers Certificate of Origin -In order for this PR to be merged you **must certify that you are able to submit your code to be included in MDAnalysis**. Read the links and then check the box if you agree. - -Code in MDAnalysis is under [LICENSE](https://github.com/MDAnalysis/mdanalysis/blob/develop/LICENSE). - -- [ ] I certify that I can legally submit this code contribution as described in the [**Developer Certificate of Origin**](https://developercertificate.org/) +I certify that I can submit this code contribution as described in the [**Developer Certificate of Origin**](https://developercertificate.org/), under the MDAnalysis [LICENSE](https://github.com/MDAnalysis/mdanalysis/blob/develop/LICENSE).