-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Python code for 3dMEPFM #3
Comments
@eurunuela I'm not really experienced with R. Is there any kind of equivalent to |
Good question. I have never written an entire library in R, I've only written scripts, so I honestly do not know. I guess we could create an R script that installs the libraries anyway 🤔 Not sure that's how R libraries handle it. |
A quick Google search has led me to the a documentation site that explains how to do it: https://r-pkgs.org/description.html |
Can 3dMEPFM operate using pure R? As in, without any AFNI C code? I just wonder if maybe 3dMEPFM could be packaged as an R package, or even all AFNI R functions together in one. |
Yes. That's doable. It runs R only and has an AFNI compatible CLI. |
It looks like John Lee started on something to that effect (https://github.com/afni/afnistats), but I don't think it ever got published to CRAN or anything. |
If adding R dependencies is too much work, another option would be to wait for the Python version we're currently working on, estimation of global fluctuations included. |
😆 Yeah that sounds better! Any clue on a timeline? |
Code is pretty much ready, working on the paper now. Should be there before the end of the year. |
@eurunuela any update on this? |
Working on improving one of the versions. Once I'm happy with it, I'll make the repo public and I'll add a Zenodo DOI. |
Thanks @eurunuela! |
This is not the PFM version I referred to in my previous comments but should be good enough to use as an equivalent to 3dMEPFM: https://github.com/eurunuela/pySPFM I'll work on adding some examples to the README. |
@eurunuela the most recent release doesn't have all of the necessary dependencies listed, but I think you fixed that problem in a later commit. Can you make a new release? |
I just made a new release. Have you tried running it? I must warn you that I have only tested some parts of the code, but not everything. I am currently on the process of moving all the code I've written in the past 4 years into 3 proper Python packages. So some things may be broken atm. |
It looks like the Action that deploys to PyPi didn't succeed. |
I see. I'll have a look at it tonight or tomorrow and get back to you. |
No rush. I just had a few minutes and decided to add the dependency. I can totally wait before circling back to this. |
I just deployed to PyPi from my computer. I don't know why the Action failed. |
It's now installing correctly, but the new problem is the AFNI dependency. I've opened an issue in the |
If the AFNI dependency is not a problem, you can already use the package. I have already dropped the dependency to generate the HRF matrix, but I still have to find a way to make |
I could probably use the AFNI+miniconda Docker image you were using for pyspfm's CI, but I'd definitely prefer to use pure Python in the future, so I'm hoping there will be a good way to update BRIK/HEAD files in the near future. 🤞 |
I agree it would be nice to have a pure Python version. But right now, adding this feature to |
Per @eurunuela in this week's tedana devs call, the pure Python version of |
@eurunuela is working on a Python implementation of 3dMEPFM, so we can use that instead of AFNI (which is harder to install for a Jupyter Book) once it's available.
Original content
I'm thinking that we should use the 3dMEPFM R code directly, rather than installing AFNI. To that end, we'll need to include R dependencies and have the relevant notebook use an R kernel instead of Python.
The text was updated successfully, but these errors were encountered: