Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ComponentSelector to match sklearn's DecisionTreeClassifier #1034

Open
tsalo opened this issue Feb 18, 2024 · 0 comments
Open

Refactor ComponentSelector to match sklearn's DecisionTreeClassifier #1034

tsalo opened this issue Feb 18, 2024 · 0 comments
Labels
refactoring issues proposing/requesting changes to the code which do not impact behavior TE-dependence issues related to TE dependence metrics and component selection

Comments

@tsalo
Copy link
Member

tsalo commented Feb 18, 2024

Summary

If we use DecisionTreeClassifier as the general template for ComponentSelector.

  • __init__() takes hyperparameters, but not data. In our case, that would be the tree, but not the comptable.
  • fit() takes training data and fits the model. In our case, comptable is training data.
  • predict() takes test data and predicts labels. In our case, comptable is the test data as well.

If we organize the tree's attributes similarly to DecisionTreeClassifier, we might be able to directly use sklearn's plot_tree.
It would also be really cool if we could figure out how to plot the decision surfaces based on features (see this example).

@tsalo tsalo added refactoring issues proposing/requesting changes to the code which do not impact behavior TE-dependence issues related to TE dependence metrics and component selection labels Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring issues proposing/requesting changes to the code which do not impact behavior TE-dependence issues related to TE dependence metrics and component selection
Projects
None yet
Development

No branches or pull requests

1 participant