Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ComponentSelector to DecisionTree #1051

Open
tsalo opened this issue Feb 29, 2024 · 1 comment
Open

Rename ComponentSelector to DecisionTree #1051

tsalo opened this issue Feb 29, 2024 · 1 comment
Labels
refactoring issues proposing/requesting changes to the code which do not impact behavior

Comments

@tsalo
Copy link
Member

tsalo commented Feb 29, 2024

Summary

This stems from #969. Now that the ComponentSelector's tree config also determines which metrics should be calculated, the name is somewhat misleading. It might make sense to rename it to DecisionTree.

@tsalo tsalo added the refactoring issues proposing/requesting changes to the code which do not impact behavior label Feb 29, 2024
@handwerkerd
Copy link
Member

With the way we're currently using nomenclature, "Decision Tree" are the steps in the process for deciding while "Selector" is the processing the does several things including validating and running the decision tree. Calling the selector "decision tree" is using a more narrow rather than a broader term.

The in-progress change is to specify which metrics to calculate and and to calculate them also in the selector object. This means both our decision tree json files and our selector object are not expanding beyond just selection. In practice, the config file that we'll be specifying with the --tree option will not be more than just the tree, but I'd be hesitant to break workflows by changing the options name.

I don't have any great suggestions for better terminology, but I'll keep thinking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring issues proposing/requesting changes to the code which do not impact behavior
Projects
None yet
Development

No branches or pull requests

2 participants