Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit selection node functions to minimal inputs #1052

Open
tsalo opened this issue Feb 29, 2024 · 1 comment
Open

Limit selection node functions to minimal inputs #1052

tsalo opened this issue Feb 29, 2024 · 1 comment
Labels
refactoring issues proposing/requesting changes to the code which do not impact behavior

Comments

@tsalo
Copy link
Member

tsalo commented Feb 29, 2024

Summary

I'd like to look into only passing minimal inputs (component table- or even just the requested metrics as lists/arrays; cross-component metrics; hyperparameters) to the selection node functions, rather than the whole ComponentSelector. I think we could probably create a class (e.g., SelectionNode) to handle any logging that goes on in the individual selection node functions at the moment.

@tsalo tsalo added the refactoring issues proposing/requesting changes to the code which do not impact behavior label Feb 29, 2024
@handwerkerd
Copy link
Member

I'll think about this more once we get the other active refactors into the code. This would be a non-trivial amount of work. I don't think this would make a meaningful computational speed or memory difference, but it has the potential to make the code slightly easier to understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring issues proposing/requesting changes to the code which do not impact behavior
Projects
None yet
Development

No branches or pull requests

2 participants