Minimum image regression relies on distinction between "accepted" and "ignored" components #1085
Labels
bug
issues describing a bug or error found in the project
discussion
issues that still need to be discussed
Summary
I'm working on refactoring the global signal regression functions in order to better understand them (particularly for #1071), and I noticed that
gscontrol.minimum_image_regression
specifically uses "accepted" components and not "ignored" components. Since we eliminated the "ignored" classification in #756, MIR likely doesn't work the way it was intended anymore.We could probably leverage the classification tags, but those vary by decision tree and are essentially up to the user.
The text was updated successfully, but these errors were encountered: