Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add elbow-less minimal decision tree #1131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add elbow-less minimal decision tree #1131

wants to merge 1 commit into from

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Sep 17, 2024

Closes #1129. I'll actually test it soon.

Changes proposed in this pull request:

  • Create a decision tree based on the minimal decision tree, with elbow nodes cut out.

@handwerkerd
Copy link
Member

Thank you!
This should also include a figure in included_decision_trees.rst (I can help make the figure) and an update to "[tedana] What are the differences between the tedana_orig, meica, and minimal decision trees?" in faq.rst. Hopefully we can have some people test & make sure this is useful before making those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding a conservative elbow-free decision tree
2 participants
@tsalo @handwerkerd